Add help note to unconstrained const parameter #76401
Merged
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
JulianKnodt
force-pushed
the
i68366
branch
4 times, most recently
from
20e023f
to
f9a20d4
Compare
|
Can you add https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=51d59876e3827706e44f9891bf73dfe8 as a test? I am not sure how well the error message reads in that case |
JulianKnodt
force-pushed
the
i68366
branch
2 times, most recently
from
75c26a7
to
7943955
Compare
jyn514
reviewed
Sep 7, 2020
jyn514
added
A-const-generics
|
📌 Commit a1fcdff374551c213f986f226505f64cb26a011e has been approved by |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a1fcdff374551c213f986f226505f64cb26a011e has been approved by |
|
@bors r=lcnr It got reset when @JulianKnodt pushed the fixes to my nit (whoops) |
|
📌 Commit ee55c1f has been approved by |
varkor
reviewed
Sep 8, 2020
| "expressions using a const parameter must map each value to a distinct output value", | ||
| ); | ||
| err.note( | ||
| "proving the result of expressions other than the parameter are unique is not supported", |
There was a problem hiding this comment.
I think the meaning of this comment may not be entirely clear to someone unfamiliar with the constraints of const generics, but I'm not sure of better wording yet. I'll have a think about it.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#76162 (Make duration_since documentation more clear) - rust-lang#76355 (remove public visibility previously needed for rustfmt) - rust-lang#76374 (Improve ayu doc source line number contrast) - rust-lang#76379 (rustbuild: Remove `Mode::Codegen`) - rust-lang#76389 (Fix HashMap visualizers in Visual Studio (Code)) - rust-lang#76396 (Fix typo in tracking issue template) - rust-lang#76401 (Add help note to unconstrained const parameter) - rust-lang#76402 (Update linker-plugin-lto.md to contain up to rust 1.46) - rust-lang#76403 (Fix documentation for TyCtxt::all_impls) - rust-lang#76498 (Update cargo) Failed merges: - rust-lang#76458 (Add drain_filter method to HashMap and HashSet) r? `@ghost`
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68366, since it is currently intended behaviour.
If demonstrating
T -> Uis injective, there should be an additional word that it is not yet supported.r? @lcnr